search

City-Bureau / city-scrapers-cle

City Scrapers project for Cleveland
https://cityscrapers.org/
MIT License
15 stars 14 forks source link

⛔ Remove pypiwin32 package #62

Closed SimmonsRitchie closed 10 months ago

SimmonsRitchie commented 10 months ago

Summary

Deletes pypiwin32 from our Pipfile and rebuilds our lock file, which appears to solve a dependency bug that was causing our CI Github workflow to fail. This same fix was implemented for our city-scrapers repo.

This PR also:

Why are we doing this?

In a recent PR I immediately experienced an identical dependency installation failure as described here in our city-scrapers repo. See that PR for further notes and discussion.

Requiring python 3.9 and the removal of chardet & twisted weren't necessary in order to resolve this issue but I felt it made sense to clean up the Pipfile while I was removing pypiwin32.

Are there any smells or added technical debt to note?

See the PR in city-scrapers for further notes and discussion.

SimmonsRitchie commented 10 months ago

@City-Bureau/pdw, I think since we were on the same page about this change in the city-scraper repo and it's pretty low-risk, I'm just going to cowboy merge this. I'm probably going to need to implement this fix for all 16 city-scraper repos, so it probably doesn't make sense for ya'll to review each change.