City-Bureau / city-scrapers-fresno

City Scrapers for Fresno
MIT License
2 stars 3 forks source link

test_title() problem as mentioned in Slack #67

Closed haileyhoyat closed 2 years ago

haileyhoyat commented 2 years ago

@jpt-c

spider: fresno_bicycle_pedestrian.py tests: test_fresno_bicycle_pedestrian.py webpage: fresno_bicycle_pedestrian.html

note: test_fresno_bicycle_pedestrian.py has all tests commented out for now, going through the tests one by one.

Summary

Issue: #0050

Replace "ISSUE_NUMBER" with the number of your issue so that GitHub will link this pull request with the issue and make review easier.

Checklist

All checks are run in GitHub Actions. You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures.

Questions

Include any questions you have about what you're working on.

ghost commented 2 years ago

Somehow your test files both wound up in the wrong folder? Moving them to where they should be (tests/ and tests/files/) I get the error locally. The CSS selector title = item.css("td:nth-child(1) font font::text").get() does not appear to be correct.

haileyhoyat commented 2 years ago

@jpt-c roger that. thanks, working on this now.

ghost commented 2 years ago

Wanted to check on the status of this one

haileyhoyat commented 2 years ago

@jpt-c

still getting that index error in the unit tests, but i am getting the correct meeting item when i run the spider so the spider works. also, i swear i'm constantly running isort/black/flake8 and they always fails CI.

Screen Shot 2022-08-28 at 11 35 43 AM Screen Shot 2022-08-28 at 11 35 04 AM
haileyhoyat commented 2 years ago

@jpt-c don't do anything, i literally figured it out a minute ago. working on it.