City-Bureau / city-scrapers-omaha

City Scrapers for Omaha
MIT License
0 stars 0 forks source link

🛠️ Fix: Azure status badge creation #63

Closed SimmonsRitchie closed 5 months ago

SimmonsRitchie commented 5 months ago

What's this PR do?

Fixes Azure env vars that are intended to create a status badge indicating whether a spider successfully ran or failed during the cron workflow.

Why are we doing this?

This env var misconfiguration issue was causing the status badge to not be created when a spider successfully runs or fails in prod. It has been observed in a number of city-scraper repos.

Steps to manually test

  1. Run the cron workflow using this branch
  2. Observe the logs during the run spider step (search the logs for "svg"). You should see status badge svg links succesfully being created and exported to an Azure container.
  3. Check either the Azure container to check that the files were successfully uploaded or check the Documenters.org scraper status page.

Are there any smells or added technical debt to note?

n/a