search

City-Bureau / city-scrapers

Scrape, standardize and share public meetings from local government websites
https://cityscrapers.org
MIT License
334 stars 311 forks source link

Issue 912: il_arts_council #916

Closed channiemills closed 5 years ago

channiemills commented 5 years ago

PR for https://github.com/City-Bureau/city-scrapers/issues/912.

I did have a question, how should I handle cancelled meetings? The website uses the location field to indicate whether a meeting is canceled or not but I wasn't sure if there was a different field I should use on the meeting object to indicate that.

pjsier commented 5 years ago

@channiemills thanks for the PR! You can pass the string of the location (or wherever might mention a cancellation) to the _get_status function in the text kwarg. More info here https://cityscrapers.org/docs/development/#status

It looks like the check for isort is failing for now though, but running the linting commands locally should fix that

channiemills commented 5 years ago

Thanks for the feedback, back to you @pjsier

pjsier commented 5 years ago

@channiemills looks great, thanks! Merging now