Closed ledaliang closed 4 years ago
@ledaliang thanks for this! It looks like this was branched off of your changes from the last PR since it's including the commits from that one that were squashed.
To make sure that the diff is clear and only includes the commits for this spider you can pull from the upstream
main
branch (formerly master
) and create the branch from that and copy over your changes into a new branch or force push to this one. Let me know if any of that isn't clear! Happy to help with this
Summary
Issue: #905
Checklist
All checks are run in GitHub Actions. You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures.
Questions