0770 Spider: Cook County Electoral Board (Suburban Cook)

turnout-coding commented 4 years ago

Summary

Issue: 0770

Checklist

All checks are run in GitHub Actions. You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures.

[x] Tests are implemented
[x] All tests are passing
[x] Style checks run (see documentation for more details)
[x] Style checks are passing
[x] Code comments from template removed

Questions

I'm not sure how far back or forward to be fetching meetings when not in archive mode. This is an .aspx page, so each meeting is an additional request. I've implemented it to fetch the previous year if we're still in March or earlier, and the next year if it's available, but can change those if there's a standard approach.
I've added some tests, but don't have any chained together from the original request to the subsequent ones. Is there a need for that kind of test?

pjsier commented 4 years ago

@turnout-coding thanks so much for the PR! I'm really sorry about this, but I think we got our wires crossed posting the issue initially because looking at it again it's an alternate page for the Board of Commissioners. It also looks like the link for the Electoral Board is only intermittently updated and probably not best for a scraper right now https://www.cookcountyclerk.com/service/electoral-board

That's our bad, and you're welcome to take another scraper! This was really well done though, I haven't used the CookieJar class before and it looks interesting here

turnout-coding commented 4 years ago

@pjsier No worries, I learned a bunch working on this one regardless! I think I'll find another scraper to do instead and comment on whatever issue I find -- thanks!

City-Bureau / city-scrapers