City-Bureau / city-scrapers

Scrape, standardize and share public meetings from local government websites
https://cityscrapers.org
MIT License
330 stars 310 forks source link

0574 spider chi ssa 52 #983

Closed sosolidkk closed 3 years ago

sosolidkk commented 3 years ago

Summary

Issue: #574

Replace "ISSUE_NUMBER" with the number of your issue so that GitHub will link this pull request with the issue and make review easier.

Checklist

All checks are run in GitHub Actions. You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures.

Questions

So, i've run into two problems. The first one was when parsing the date, the months were written incorrectly. My solution was to have a list of months and check the ratio comparing the right month string versus the wrong month string, and if the ratio is above 0.5, the incorrect string is replace with the correct one in the list. And about the test, i think i've written few tests and i would some guidance to improve them.

sosolidkk commented 3 years ago

Hey @pjsier thanks for the tips. I've updated the code based on your suggestions!

sosolidkk commented 3 years ago

Done @pjsier ! Thanks for the help.