All checks are run in GitHub Actions. You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures.
[x] Tests are implemented
[ ] All tests are passing
[ ] Style checks run (see documentation for more details)
[ ] Style checks are passing
[x] Code comments from template removed
Comments
Glad to say after months I'm finally doing working on this spider as my first ever pull request. Thanks for the opportunity as I learned a lot. I used scrapy meta arguments for each crawl since the self keyword didn't make each item unique and would repeat values. The code for tests might seem "weird" but scarped information can vary when working with PDFs so I tried a general approach.
Summary
Issue: #914
Checklist
All checks are run in GitHub Actions. You'll be able to see the results of the checks at the bottom of the pull request page after it's been opened, and you can click on any of the specific checks listed to see the output of each step and debug failures.
Comments
Glad to say after months I'm finally doing working on this spider as my first ever pull request. Thanks for the opportunity as I learned a lot. I used scrapy meta arguments for each crawl since the self keyword didn't make each item unique and would repeat values. The code for tests might seem "weird" but scarped information can vary when working with PDFs so I tried a general approach.