search

City-of-Bloomington / open311-ios

GeoReporter iOS source code. Native iOS smartphone client app for Open311 API civic issue reporting.
http://open311.org
Other
23 stars 22 forks source link

About screen is cropped off at top #197

Closed inghamn closed 11 years ago

inghamn commented 11 years ago

The webview for the about screen is going underneath the navigationBar. Because of this, the top of about page is not visible, since it is covered by the navigationBar.

We need for the webview to not go underneath the navigationBar.

inghamn commented 11 years ago

This works fine on the iPhone 5, but on earlier, shorter phones, the top gets cropped off.

mariusc commented 11 years ago

Fixed in 1103849fe9cd233de434c4ef47b5e8476f806490. I added a scrollview as the root of the AboutController. This seemed to fix it :).

inghamn commented 11 years ago

Thanks for taking a look. I was hoping it was some simple thing.

Now the bottom is cropped off, and you cannot scroll down without it snapping back.

inghamn commented 11 years ago

I don't think it should need a scrollview. The webview is scrollable all by itself. I might try just having the top limit and see if that helps.

inghamn commented 11 years ago

Webview doesn't allow setting contentOffset. I think it might be simplest to just add some CSS to the about.html that moves the content down the page a bit.

mariusc commented 11 years ago

I think I found a way around it somehow. I got rid of the scroll view and changed the translucent property of the navigation bar. It seems to be ok now. Not really sure why, but everything seems fine :). I'm pushing a commit now

inghamn commented 11 years ago

It seems when you have a translucent navigationBar, the content area for child views goes underneath the navigationBar. ScrollViews have a setting for contentOffset to account for this, however webViews do not.

mariusc commented 11 years ago

Pushed d858e1eaf9b47f6b9932847b28de4e39f73267ea. This seems to fix it. Will close this issue if everything is fine

inghamn commented 11 years ago

That fixed it!. Thanks for the help. I'm going to try and get this submitted to the app store today.