Modify external links in FAQs to open in new window

City-of-Helsinki / cnh-ui

Helsinki Climate Watch - Climate strategy monitoring UI

https://ilmastovahti.hel.fi

GNU Affero General Public License v3.0

2 stars 4 forks source link

Modify external links in FAQs to open in new window #65

Open iqqmuT opened 4 years ago

iqqmuT commented 4 years ago

Kinda a rough way to modify existing links to open in new window. This patch assumes that links do not already contain target attribute.

juyrjola commented 4 years ago

Uhh, seems a bit fragile. How about this instead? https://www.npmjs.com/package/posthtml-external-link-target-blank

juyrjola commented 4 years ago

Oh, and this code applies also to Action.description, Indicator.description, ActionUpdate.content and ActionTask.comment.

iqqmuT commented 4 years ago

Thanks for direction! Created a new component HtmlContent to wrap all HTML renderings. That component should be the only place where prop dangerouslySetInnerHTML is used.