search

City-of-Helsinki / maritime-maas

MIT License
0 stars 3 forks source link

MAAS-101 | Fix StopSerializer.departures not using distinct StopTimes #64

Closed charn closed 3 years ago

charn commented 3 years ago

This PR fixes an issue where the API was not returning distinct StopTimes (departures in the API) when a stop appeared more than once on a trip. If the same stop appeared more than once on a trip (when visiting the same place more than once during a trip), the API didn't properly return the stop times for additional visits to the same stop.

codecov-commenter commented 3 years ago

Codecov Report

Merging #64 (335d1c2) into main (7c184d0) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   88.56%   88.54%   -0.03%     
==========================================
  Files          48       48              
  Lines        1522     1519       -3     
  Branches      118      118              
==========================================
- Hits         1348     1345       -3     
  Misses        140      140              
  Partials       34       34
Impacted Files Coverage Δ
gtfs/api/stops.py 98.80% <100.00%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c184d0...335d1c2. Read the comment docs.