City-of-Helsinki / mlops-template

Generic repository template for small scale MLOps
Apache License 2.0
24 stars 8 forks source link

Add pre-commit hooks to container #42

Closed jussiarpalahti closed 1 year ago

jussiarpalahti commented 1 year ago

As specified here

Run git hook installation setup either just inside Devcontainer or in Dockerfile as well.

jussiarpalahti commented 1 year ago

As per instructions you can't actually force Git repository to use git hooks without user's opt-in. Which is a good thing, I guess. This means, that instructions need to be updated on that topic. Inside dev container I should think installation of Git hooks can be mandatory, so they'll work from inside Codespaces.

nakytoe commented 1 year ago

Agree. Dockerfile install was removed because otherwise papermill parameterisation tags were cleaned from the notebooks. Now this should not be an issue

nakytoe commented 1 year ago

The template should also be used dockerized by default, whether or not with code spaces