Initial go at wagtail2 - Githubissues

City-of-Helsinki / wagtail-svgmap

ImageMap functionality for Wagtail through inline SVGs

BSD 3-Clause "New" or "Revised" License

13 stars 8 forks source link

Closed stuaxo closed 6 years ago

stuaxo commented 6 years ago

I had a bit of a go at wagtail2.

Haven't worked out how to get testing working so no idea if this works yet.

akx commented 6 years ago

Code looks nice, but that Travis matrix failure is pretty weird indeed!

stuaxo commented 6 years ago

I tried so many combinations .... and couldn't work out how to do it.

Almost tempting to have an explicit entry for each combination ?

akx commented 6 years ago

Sure, that'll work. Not too many combinations so far anyway, so go ahead :)

stuaxo commented 6 years ago

The nice folks at Travis pointed out the fix - case was wrong in the exclude rule.

stuaxo commented 6 years ago

Hey @akx any chance of merging this ?

I've been procrastinating on my sites feature that uses wagtail-svgmap, and if this is merged I'll have no excuse..

akx commented 6 years ago

Looks good! I'll squash-merge these. Thank you for the work! :)

stuaxo commented 6 years ago

Awesome ! Right, I have no excuse now but to use this :D

Look forward to seeing it on pypi ;)