CityBaseInc / airbrake_client

Airbrake client to report errors and exceptions to Airbrake.io.
Other
0 stars 1 forks source link

Consider changing to Jason json library #27

Closed nacengineer closed 1 month ago

nacengineer commented 8 months ago

The poison library has quite a few open issues. Including at least one for coming Elixir deprecations, e.g. use Bitwise, and devinus has been silent on adopting it/them. Not saying poison is dead but 2 years without pulling in easy PRs is kind of that to me.

Consider pivoting to the more maintained Jason library.

jdfrens commented 3 months ago

There's an unadvertised config option: :json_encoder.

config :airbrake_config, 
   ...
  json_encoder: Jason,
  ....

I'm reluctant to make Jason the default because it'll blow up on structs that don't have encoders (where I think Poison just encodes them as maps).

nacengineer commented 1 month ago

The poison developer has woken up and released a ver 6. Closing this one. Thanks for the info.

Although FWIW Jason will probably be the easiest to leverage the new native json library in erlang soon so you might still want to investigate this one. :)