search

CityGenerator / Megacosm-Generator

A tool for creating fantasy campaign settings, including maps, regions, flags, cities, NPCs, businesses, legends, lore and more.
GNU General Public License v2.0
69 stars 30 forks source link

#75 and #77 - Two new one liner generators for Drink and Elixir #128

Closed JttWest closed 8 years ago

JttWest commented 8 years ago

These are 2 new one liner generators for creating Drink(issue #77) and Elixir (issue #75). The name for the Elixir generator was suppose to be Potion but there's already a Potion.data so it was renamed to Elixir instead.

JttWest commented 8 years ago

The unit test for Drink generator has be commented out temporary as it seems like it require DB update.

morgajel commented 8 years ago

Overall I think Drinks is a great addition, but I'm a little shaky on Elixirs because it is so close to the magicitem potions:

http://megacosm.morgajel.net/magicitem?magicitem_kind=2

However, since I left the magicitem potions in a crappy broken state, I'm ok with adding Elixirs.

The Dataset still needs to be cleaned up a bit (see previous comments), and I'll need to test the branch at home first, but it's looking very nice.

JttWest commented 8 years ago

Yes it's for a software engineering course. The project is to contribute to an open source project on GitHub and write a report on it.

morgajel commented 8 years ago

That is outstanding; make sure to tell your Prof that us OSS devs appreciate his efforts and to "send more our way" :)

Thank you again for your contribution; I'll merge your changes when I get some time to tweak the textfile (hopefully in January).