CityOfBoston / CityWorker-issues-Incapsulate

Archived for legacy purposes
0 stars 0 forks source link

Case closure comments not being shown on CW App #113

Closed limadog2003 closed 6 years ago

limadog2003 commented 6 years ago

Just a small issue, but when a case is closed within CW, the comments and internal comments are shown, but the case closure has a comment line that is blank, as you can see from the screen shot below (highlighted). Again, no loss of data or functionality, just a small bug.

screenshot_20180501-114533

jqr commented 6 years ago

@limadog2003 What are you expecting in this area?

limadog2003 commented 6 years ago

Stressing very minor issue, but I would remove the "Comment: " string from this part of the closed activity

aggie7 commented 6 years ago

@jqr should be "here are closing comment" I was able to reproduce it on other tickets as well (Unsafe building conditions #18-00015983)

jqr commented 6 years ago

@aggie7 The case above, 18-00015979, does not have a case closure reason. Here's the excerpt from the API.

{
  # ...
  :closure_details => {
    :reason  => "Case Noted",
    :comment => nil
  }
}

Same for 18-00015983:

{
  # ...
  :closure_details => {
    :reason  => "Case Resolved",
    :comment => nil
  }
}

The setting of this comment field is not done by Spot Server, so I'm going to interpret this Issue as "we should omit the comment string if it's nil.

P.S. When you type #something in GitHub it will link it to another Issue with that id, 18 in this case. You can type \#something if you want to avoid it, or you can just omit the # sign.

jqr commented 6 years ago

This is deployed and should be fixed now. Thanks for reporting @limadog2003.