search

CityOfBoston / CityWorker-issues-Incapsulate

Archived for legacy purposes
0 stars 0 forks source link

Closed photos are not visible to citizens's request in test BOS:311 (orange app) #68

Closed vanessacalderon closed 6 years ago

vanessacalderon commented 6 years ago

Sorry for my silence. I will re-test again as soon as we get this packages resolved. Meanwhile, I noticed that the current BOS311 test does not show the closed photos, like the current version does. Recap Current BOS311- citizen creates a case and uploads photo. Photo is tagged as submitted. City worker closes cases and takes photo(s). Citizen checks their closed case in BOS311 and sees the submitted photo and closed photo.

Test BOS311- citizen creates a case and upload photo. Photo is tagged as submitted. City worker closes cases and takes photo(s). Citizen checks their closed case in BOS311 and does not see the closed photo, only the submitted photo.

CURRENT BOS311 Submitted photo from the citizen image

Closed photo the citizen can see on My Reports or Recent image

TEST BOS311 Submitted photo. Cannot see the closed photos I added in CW image

Closed photos I added in CW when I closed the case image

jqr commented 6 years ago

Thanks for catching this! It looks to have been a regression due to the way I was handling idempotent history generation for Transfer/Reallocate.

I've deployed a fix and tested it. It looks good to me but can you verify? I did notice there are some Services for which Activity outcome photos are not visible to BOS311's API key so be mindful of that.

vanessacalderon commented 6 years ago

I closed several cases in SF (via case or via activity and added a photo to the case or activity) and checked BOS311 (My Reports) and I could not see the closing photos.

Open case in BOS311 image

Closing photo in tied to the activity outcome image

Photo of the street light

image This is the case in BOS311 image

This in an abandoned vehicle case image

Closed case via case (not activity) . HEre is the photo of the car image

image

Here is BOS311 image

jqr commented 6 years ago

I deployed a new fix which I think should address this.

The permission checking code was not inspecting photos attached to an Activity to see if the reporter had access.

vanessacalderon commented 6 years ago

For any activity outcome that closes the case, I get a reallocation. The reallocation then has no reason in SF, it changes the queue to Elissa, no outcome is being passed back to SF and the status for the first activity is not Complete or In - Progress (if it were truly a reallocation). This is all wrong now...

image

image

image

image

image

vanessacalderon commented 6 years ago

@limadog2003

jqr commented 6 years ago

For any activity outcome that closes the case, I get a reallocation. The reallocation then has no reason in SF, it changes the queue to Elissa, no outcome is being passed back to SF and the status for the first activity is not Complete or In - Progress (if it were truly a reallocation). This is all wrong now...

@vanessacalderon We're investigating that issue, but it's separate from this. I've made an issue about it in this repo as #106.

vanessacalderon commented 6 years ago

Did the test again. I completed case 15721 with two photos but I noticed that BOS311 only displays one. Not sure how it picks one but now that your CW version allows for multiple photos, BOS311 will have to display all closed photos.

image

vanessacalderon commented 6 years ago

I noticed this same issue in BOS311 in Dev. BOS311-Dev only displays one closed photo, while BOS311-Lagan displays more than one closed photo.

jqr commented 6 years ago

Can you be explicit about what you mean by BOS311-Dev and BOS311-Lagan.

vanessacalderon commented 6 years ago

Sure, by BOS311- Dev I mean the application that is connected to Salesforce Dev (server boston2spotworkforce.net). By BOS311- Lagan I mean the BOS311 application that is currently live and connected to Lagan (I believe the server is called Boston?). Check a closed case in the latter and you will see more than one photo for closure.

jqr commented 6 years ago

@vanessacalderon Do you have a request number handy?

vanessacalderon commented 6 years ago

Sure: all these have 3 photos. 1 creation, 2 closure I am guessing: case #101002562897, #101002267833, #101002465132, #101002588946. This case is closed but has 2 photos, #101002588938. Closed photo is a logo. My ultimate point is, if City Worker allows for uploading multiple pictures upon closure, then why wouldn't the city be able to see ALL the photos a city worker staff submitted if the purpose is to increase citizen communication? I am not sure what your purpose it (company you, not you)

vanessacalderon commented 6 years ago

repeating paragraph. Monday I guess and I don't know how to spell...

My ultimate point is, if City Worker allows for uploading multiple pictures upon closure, then why wouldn't the citizen be able to see ALL the photos a city worker staff submitted if the purpose is to increase citizen communication? I am not sure what your purpose is (company you, not you)

jqr commented 6 years ago

BTW you can edit your previous messages! 🙂

jqr commented 6 years ago

These case numbers look abnormal as they usually start with the year (18-000...). Additionally, I'm not able to locate them within Salesforce via the API. Are these for the Dev environment?

jqr commented 6 years ago

I can answer one question ahead of time though. Image permissions are handled by querying Incapsulate using the Workforce and the Citizen keys, then comparing the results. If the Citizen can see it, it's public, if only the Worker can see it, it's internal only.

vanessacalderon commented 6 years ago

Duhh, thanks for the tip. Next time I will edit the reply :) The case numbers I gave you are not from Salesforce. They are from Lagan. Those are cases in the boston server that is running our Boston Live BOS311 app. Sorry, I thought you wanted to see examples of the current environment with more than one closure photo as proof of what I am saying. Here is an example in Salesforce Dev. Case 18-00017060. It has 3 photos. The BOS311 only displays the photo of the map. There is no private/public option on the CW app that the city worker would click (only in SF and I did not mark them as private). So, as far as this case goes, all 3 photos are public.

jqr commented 6 years ago

This is related to #123 but not quite the same.

The current integration code goes through all Activities looking for the first public photo which has a tag of Update.

I think we need to decide on which photos classify as outcome photos. It sounds like you're saying that maybe it's these scenarios:

  1. Cases media_url that has a tag of at least Close.
  2. Activities media_url that has a tag of at least Update when viewed through the API as a Reporter.

Is there anything else?

Should all of those be outcome photos, or the earliest one, ...?

Either way this is worth discussing and documenting! 🙂

davemitchell commented 6 years ago

Let’s check in with Fin. I seem to recall that they implemented some newer logic on the web portal... maybe just showing all accessible photos without attempting to categorize them?

vanessacalderon commented 6 years ago

These are the tags that are available (we did not ask for these, they suddenly appeared). Not sure we can lock down the tags to only show Open/Close for users. This means they could pick whatever they want, if the photos are attached by users and not by integration.

File to Photo--> adding a photo at the case level Tags: Close, Create, Update, Transfer, Closed, Submitted, Inspected.

[image: image.png]

Files--> adding a photo at the activity level (SACT)

Tags: Close, Create, Update, Transfer, Closed, Submitted, Inspected.

[image: image.png]

On Thu, Sep 20, 2018 at 6:03 PM dave mitchell notifications@github.com wrote:

Let’s check in with Fin. I seem to recall that they implemented some newer logic on the web portal... maybe just showing all accessible photos without attempting to categorize them?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CityOfBoston/CityWorker-issues/issues/68#issuecomment-423348900, or mute the thread https://github.com/notifications/unsubscribe-auth/AfC5vWbIBW3C5eKiG7-g5j8rEf0upV90ks5udBC-gaJpZM4SXBJA .

--

[image: COB_B_Blue_square-01.png]

Vanessa Calderón

CRM Specialist

City of Boston | DoIT

vanessa.calderon@boston.gov

617.635.4412 (w)

vanessacalderon commented 6 years ago

image

image

jqr commented 6 years ago

@karthikakula recognized the impossibility of Spot Server knowing that an Activity outcome causes Case closure, and consequently, that images with that Activity should be considered outcomes. He's going to look at options for choosing the tag based on the outcome instead of the action and documenting their usage.

vanessacalderon commented 6 years ago

BOS311API-177 - closing this Github. We will keep it in JIRA since it is on Incapsulate @Jailalwani