Closed reillyzlab closed 2 years ago
Dependent on design designating what each color layout looks like - corresponding ticket: https://github.com/CityOfBoston/boston.gov-d8/issues/322
Updating all components this way would likely exceed a week (largest sprint label).
Need to determine which components currently can be themed, just to make sure the above checklist is still correct.
Components ready for review and feedback:
On gray background page, the following need the department contact fixed. This should be red with light blue hover to match the other components (example below):
-- On white background page:
The following need the department contact fixed. This should be red with light blue hover to match the other components (example below):
Event and notices:
-- On dark blue background page:
The department contact is inconsistent in coloring. These should be consistent. Few examples of how they vary. @sebastianebarb @carolinestj to advise how to handle this
Events and notices:
@padora-cob @sebastianebarb realize it wasn't originally on the ticket but is there a reason we didn't do the commissions components?
@padora-cob @sebastianebarb realize it wasn't originally on the ticket but is there a reason we didn't do the commissions components?
I don't think so, I simply went off the list above. I think there could be a few more components we could add this to though. Would just want to add them to the list so I don't lose track with all the files flying around.
we should check that the red #D22D23 is accessible on the dark blue background, when I check it it fails. The lighter red #FB4D42 passes though!
Example:
Aside from the issues @reillyzlab flagged, here are some others. This is specifically for the "blue" theme:
It's a little different, but I imagine this would cause an accessibility issue.
Normal:
Hover state
There's extra white space in between this "maps" and "emergency alerts" component:
The space is real tight in between the "iframe" and the "emergency alerts" component:
If you click and drag over that section, you can see the missing text:
For the "white" themed components, here are some minor issues:
There are also some minor issues with the "gray" components:
"Drawers" and "quick links" components:
"Group of links - list" and "photo" components:
"Grid of cards" and "photo" components:
"FYI" and "photo" components:
"Formatted text" and "photo" components:
"Map" and "emergency alerts" components:
And it's tight in between the "emergency alert" and "iframe" components:
Last thing, across all of the color themes, the hover state for the "grid of guides" has some random red color in the background:
Blue:
Gray:
White:
Estimated about 1 weeks worth of work for this.
Closing this ticket; work is now being accounted for in Jira.
Allow [nearly] all components to change color theme between white, gray, or blue
Components that still need: