CityOfBoston / boston.gov-d8

The official repository City of Boston public website, boston.gov.
https://boston.gov
Other
30 stars 20 forks source link

Add ability to choose theming for select components #322

Closed reillyzlab closed 2 years ago

reillyzlab commented 5 years ago

Allow [nearly] all components to change color theme between white, gray, or blue

Components that still need:

reillyzlab commented 5 years ago

Dependent on design designating what each color layout looks like - corresponding ticket: https://github.com/CityOfBoston/boston.gov-d8/issues/322

jimafisk commented 5 years ago

Updating all components this way would likely exceed a week (largest sprint label).

andrebtlima commented 4 years ago

Need to determine which components currently can be themed, just to make sure the above checklist is still correct.

padora-cob commented 3 years ago

Components ready for review and feedback:

reillyzlab commented 3 years ago

On gray background page, the following need the department contact fixed. This should be red with light blue hover to match the other components (example below):

Screen Shot 2021-05-11 at 10 48 11 AM

-- On white background page:

  1. The following need the department contact fixed. This should be red with light blue hover to match the other components (example below):

    • [ ] three column with image
    • [ ] Grid of guides Screen Shot 2021-05-11 at 11 12 47 AM
  2. Event and notices:

    • [ ] I think the featured event/notice needs a box or something to frame the content - @sebastianebarb or @carolinestj to advise?
    • [x] There is something funny happening when events are 'canceled' -- see: Screen Shot 2021-05-11 at 11 12 03 AM

-- On dark blue background page:

  1. The department contact is inconsistent in coloring. These should be consistent. Few examples of how they vary. @sebastianebarb @carolinestj to advise how to handle this

    Screen Shot 2021-05-11 at 11 37 52 AM Screen Shot 2021-05-11 at 11 38 01 AM
  2. Events and notices:

    • [x] There is something funny happening when events are 'canceled' -- see: Screen Shot 2021-05-11 at 11 41 59 AM
reillyzlab commented 3 years ago

@padora-cob @sebastianebarb realize it wasn't originally on the ticket but is there a reason we didn't do the commissions components?

padora-cob commented 3 years ago

@padora-cob @sebastianebarb realize it wasn't originally on the ticket but is there a reason we didn't do the commissions components?

I don't think so, I simply went off the list above. I think there could be a few more components we could add this to though. Would just want to add them to the list so I don't lose track with all the files flying around.

carolinestj commented 3 years ago

we should check that the red #D22D23 is accessible on the dark blue background, when I check it it fails. The lighter red #FB4D42 passes though!

Example: Screenshot 2021-05-11 150342

duffy-james commented 3 years ago

Aside from the issues @reillyzlab flagged, here are some others. This is specifically for the "blue" theme:

  1. The "short description" field in the individual drawers appears to be a blue color that's blending into the background slightly:

image

It's a little different, but I imagine this would cause an accessibility issue.

  1. The "short description" for the individual links in the "group of links - list" with and without description components is blending into the background. You can only see the text when you hover over the link with your mouse:

Normal:

image

image

Hover state

image

image

  1. The "newsletter" component has extra white space at each corner of the component:

image

  1. This is related to the spacing issues in between components, but I'm still seeing extra white space and other issues. It might just be related to the "emergency alerts" component, as that is the common denominator.

There's extra white space in between this "maps" and "emergency alerts" component:

image

The space is real tight in between the "iframe" and the "emergency alerts" component:

image

  1. The "featured" event also appears to be missing text because it's blending into the background:

image

If you click and drag over that section, you can see the missing text:

image

duffy-james commented 3 years ago

For the "white" themed components, here are some minor issues:

  1. The "short description" text in the individual "drawers" of the "drawers" component blends into the background:

image

  1. There's extra spacing in between the "FYI" component and a "photo" component:

image

duffy-james commented 3 years ago

There are also some minor issues with the "gray" components:

  1. There's extra spacing in between a few components (probably a separate issue, but just a flag):

"Drawers" and "quick links" components:

image

"Group of links - list" and "photo" components:

image

"Grid of cards" and "photo" components:

image

"FYI" and "photo" components:

image

"Formatted text" and "photo" components:

image

"Map" and "emergency alerts" components:

image

And it's tight in between the "emergency alert" and "iframe" components:

image

  1. The "newsletter" component also has four white corners:

image

duffy-james commented 3 years ago

Last thing, across all of the color themes, the hover state for the "grid of guides" has some random red color in the background:

Blue: image

Gray: image

White: image

stephaniemar commented 2 years ago

Estimated about 1 weeks worth of work for this.

duffy-james commented 2 years ago

Closing this ticket; work is now being accounted for in Jira.