search

CityOfBoston / budget.boston.gov

Budget.boston.gov is a web application that displays the City of Boston’s budget books online.
https://budget.boston.gov
7 stars 12 forks source link

Broken Images #216

Open jimafisk opened 6 years ago

jimafisk commented 6 years ago

Across the site there are images that are not rendering, for example: https://budget.boston.gov/featured-analysis/city-services/

This is happening because of an extra forward slash character: bad_img

If we remove that misc / from the template, the image should render: https://budget.boston.gov/img/15-average-dept-increase.png

jimafisk commented 6 years ago

Example of broken image:

extra_forward_slash

Example of adjusted path so image renders:

without_extra_forward_slash

List of known components that have the forward slash in the template:

reillyzlab commented 6 years ago

Not a priority

paulparisi commented 6 years ago

@jimafisk I begin the path with an initial / - should the JSON not have this? I have removed it for now.

private comment to self - look for "img/" to find these in the source code

jimafisk commented 6 years ago

Hey @paulparisi I don't think this is something you need to worry about on your end. I think it was mostly related to the manually created pages, so the way you were doing things previously should be ok. I've actually already fixed this particular issue, it just didn't deploy correctly.