CityOfBoston / budget.boston.gov

Budget.boston.gov is a web application that displays the City of Boston’s budget books online.
https://budget.boston.gov
7 stars 12 forks source link

JSON Not Rendering? #278

Closed paulparisi closed 6 years ago

paulparisi commented 6 years ago

phc-administration.json.txt

Take a look at this JSON file which is located at

\JSON Output_source\fy19_recommended\json_programs\health-and-human-services\public-health-commission

The page you suggested does not match the JSON above.

https://budget.digital-staging.boston.gov/operating-budget/cabinets/health-and-human-services/public-health-commission/phc-administration/

jimafisk commented 6 years ago

Here's the corresponding JSON source on GitHub: https://github.com/CityOfBoston/budget.boston.gov/blob/develop/_source/fy18_recommended/json/_programs/health-and-human-services/public-health-commission/administration.json

Is the main issue that not all the information from the JSON file is making it to the page? The way we produced for fy18_recommended was the JSON source had tons of information in it that we never used. We pulled out the critical aspects into a template and ignored the rest. @paulparisi are there specific areas that displayed previously, but no longer do?

paulparisi commented 6 years ago

Ah - there is quite a bit of code running to produce the JSON. I was not aware that large parts were not rendered. I understood that certain keys would be ignored but not that large sections.

So, is there a way to tell me what is not being rendered?

This will allow me to greatly simplify the output. Right now, for example, the bureaus is a complicated set of data the OBM does not even have sources for. So my output routine broke and I did not know why I could not see it in the HTML.

jimafisk commented 6 years ago

Ok that makes sense. I don't definitively know enough about what should or should not be rendered on the site. I can tell you what we did last year. Here's the same page on the live site: https://budget.boston.gov/operating-budget/cabinets/health-and-human-services/public-health-commission/administration/

I'd defer to @jimwilliamson-boston as to whether or not bureaus should be rendering. Thanks!

jimwilliamson-boston commented 6 years ago

We do not capture PHC bureau-level data in Hyperion so it is not part of the data used in BudgetSoft 2-3.

On Fri, Mar 30, 2018 at 9:30 AM, Jim Fisk notifications@github.com wrote:

Ok that makes sense. I don't definitively know enough about what should or should not be rendered on the site. I can tell you what we did last year. Here's the same page on the live site: https://budget.boston.gov/ operating-budget/cabinets/health-and-human-services/ public-health-commission/administration/

I'd defer to @jimwilliamson-boston https://github.com/jimwilliamson-boston as to whether or not bureaus should be rendering. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CityOfBoston/budget.boston.gov/issues/278#issuecomment-377524441, or mute the thread https://github.com/notifications/unsubscribe-auth/AaCUjDreYeoxBZaZbuuo6LEVXqjUdDOxks5tjjN3gaJpZM4S_SWP .

paulparisi commented 6 years ago

I have removed the PHC bureau functions from the code. We should be able to close this.