search

CityOfBoston / dog-licenses

Other
0 stars 0 forks source link

Graphql fields and sql search complete #16

Closed powazek closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@4f5893a). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #16   +/-   ##
==========================================
  Coverage           ?   64.14%           
==========================================
  Files              ?       34           
  Lines              ?      463           
  Branches           ?        0           
==========================================
  Hits               ?      297           
  Misses             ?      166           
  Partials           ?        0
Impacted Files Coverage Δ
server/services/Registry.js 42.59% <ø> (ø)
server/graphql/dog-licenses.js 35.71% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f5893a...f6620fd. Read the comment docs.

fionawhim commented 7 years ago

Probably delete that code, too?

On Wed, Jul 19, 2017 at 10:03 AM, powazek notifications@github.com wrote:

@powazek commented on this pull request.

In server/services/Registry.js https://github.com/CityOfBoston/dog-licenses/pull/16#discussion_r128255061 :

export type DogLicense = {|

  • CertificateID: number,
  • 'Registered Number': string,
  • InOut: 'I' | '*' | '#',
  • 'Date of Death': ?string,
  • 'Decedent Name': string,
  • 'Last Name': string,
  • 'First Name': string,
  • RegisteredYear: string,
  • AgeOrDateOfBirth: string,
  • Pending: number,
  • CertificateID: string,

The reason it's still there is that it is included in later code in Registry.js that does data output stuff, and when I remove it it throws errors that require deleting lots of code :/ thoughts?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/CityOfBoston/dog-licenses/pull/16#discussion_r128255061, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP65bRgSFRkam31Vss6L-jE05cZrS56ks5sPgy2gaJpZM4Ob4Ih .

--

[image: COB_B_Blue_square-01.png]

Fin Hopkins

Software Engineer, Digital Team

Department of Innovation and Technology (703)

fin.hopkins@boston.gov

they / them / theirs

fionawhim commented 7 years ago

5irrqle