search

CityOfBoston / dog-licenses

Other
0 stars 0 forks source link

Delete extra death cert code #17

Closed powazek closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #17 into develop will decrease coverage by 14.97%. The diff coverage is 18.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #17       +/-   ##
============================================
- Coverage    64.14%   49.17%   -14.98%     
============================================
  Files           34       25        -9     
  Lines          463      362      -101     
============================================
- Hits           297      178      -119     
- Misses         166      184       +18
Impacted Files Coverage Δ
client/dogs/search/SearchResult.js 100% <ø> (ø) :arrow_up:
client/page.js 100% <ø> (ø) :arrow_up:
server/services/Registry.js 42.59% <ø> (ø) :arrow_up:
server/graphql/dog-licenses.js 35.71% <ø> (ø) :arrow_up:
client/dao/DogLicensesDao.js 84.61% <ø> (-15.39%) :arrow_down:
client/queries/search-dog-licenses.js 100% <ø> (ø) :arrow_up:
client/dogs/FormPage.js 0% <0%> (ø) :arrow_up:
client/common/Nav.js 0% <0%> (-72.73%) :arrow_down:
client/dogs/SearchPage.js 53.33% <100%> (-17.04%) :arrow_down:
client/common/Pagination.js 0% <0%> (-92.31%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3df25aa...e68c913. Read the comment docs.

fionawhim commented 7 years ago

ok to hold off on deleting this until later

On Wed, Jul 26, 2017 at 1:29 PM, powazek notifications@github.com wrote:

@powazek commented on this pull request.

In client/dogs/SearchPage.js https://github.com/CityOfBoston/dog-licenses/pull/17#discussion_r129641142 :

  • if (query.q) {
  • if (query.firstName && query.lastName && query.dogName && query.year) {

Ah- I haven't moved the search results to the form page yet. Wanted to make the dependencies commit first and then add all the graphql params and move the function over. Should I still remove this code?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CityOfBoston/dog-licenses/pull/17#discussion_r129641142, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP65S_DfRhTfzfDE5zIeBd2VV7D_nkeks5sR3dkgaJpZM4OkEAg .

--

[image: COB_B_Blue_square-01.png]

Fin Hopkins

Software Engineer, Digital Team

Department of Innovation and Technology (703)

fin.hopkins@boston.gov

they / them / theirs