search

CityOfBoston / patterns

The City of Boston pattern library for public-facing websites.
https://patterns.boston.gov/
24 stars 9 forks source link

GRID OF QUOTES #553

Closed subaha-cob closed 2 years ago

subaha-cob commented 3 years ago

https://d8-uat.boston.gov/departments/digital-team/test-page GRID OF QUOTES

Screen Shot 2021-06-30 at 4 53 48 PM

Suggested naming conventions: Base: goq

Elements: h = header c = content im = image t = title st = subtitle

Modifier: sm = small

subaha-cob commented 3 years ago

@mharoc you have had this task for a while now. Where are we at with this task?

rachelsater commented 3 years ago

@duffy-james This looks correct to me. Can you please review it and let me know what you think?

subaha-cob commented 3 years ago

Also on this page @rachelsater https://d8-uat.boston.gov/career-center

rachelsater commented 3 years ago

@subaha-cob Is there meant to be a space between the " and the first/last letter? image

subaha-cob commented 3 years ago

Yes ;)

rachelsater commented 3 years ago

@subaha-cob ok thanks! @duffy-james This seems to make the design. What do you think?

duffy-james commented 3 years ago

@rachelsater the display looks fine -- @subaha-cob we're just focusing on the front-end with this, right?

There was an issue where users couldn't upload images to this component in the normal way, but I assumed that's separate of this work.

rachelsater commented 3 years ago

@subaha-cob If this ticket is just for the FE, we can move it to "ready for production"

subaha-cob commented 3 years ago

@rachelsater "FE" 💁🏻?

rachelsater commented 3 years ago

@subaha-cob sorry! Front end :)

subaha-cob commented 3 years ago

@rachelsater this is not just front end. I changed the markup as well.

rachelsater commented 3 years ago

@subaha-cob ah ok! I'll move it to "ready for production"