CityOfBoston / vision-zero

2 stars 1 forks source link

Only load 5 years of data #67

Closed paylakatel closed 1 year ago

paylakatel commented 1 year ago

This PR changes the Vision Zero Map to only load and display the last five years of data.

Bug: The map currently shows no data on initial load despite the count in the upper left indicating there are 779 crashes during this time frame.

Screen Shot 2023-04-30 at 12 39 14 PM

Likely cause: The crashes feature layer's Max Record Count is set to 32000 and the map is trying to load every feature in it, but the feature layer currently has 33054 features in it. When the data is loaded, the last 1054 features are missing and do not display on the map.

Screen Shot 2023-04-30 at 12 40 15 PM

Fix: This PR makes the map dynamically load the last five years of data (20057 features currently) instead of trying to load everything (data goes back to 2014). Map on load with fix:

Screen Shot 2023-04-30 at 12 44 21 PM
davidrkupton commented 1 year ago

@duffy-james Kayla pushed this a few weeks ago, and I think the code change is fine.
Also the Mayor's name on the page does need updating. This is a good catch by Kayla and fixes a prod issue - we should also check back with the stakeholder on the status of this app.

davidrkupton commented 1 year ago

@paylakatel thank you for this update, we appreciate it !

davidrkupton commented 1 year ago
davidrkupton commented 1 year ago

311 Case# 101004864098

davidrkupton commented 1 year ago

This was replaced with https://github.com/CityOfBoston/vision-zero/pull/68 which merges to the correct branch.