CityOfDetroit / bloom

component-based web framework for affordable housing management
Apache License 2.0
16 stars 1 forks source link

1577/download button can show and be non functional #1621

Closed KrissDrawing closed 1 year ago

KrissDrawing commented 1 year ago

Pull Request Template

Issue Overview

This PR addresses #1577

Description

It will hide download button, when application is present but nothing to download. We we're hiding apply sections based on application methods presence, so now i got to create some more conditions, as that one is not accurate anymore.

How Can This Be Tested/Reviewed?

edit application process in partners to have Is there a paper application? set to yes, but leave text field below empty. It shouldn't change way the listing on public site is displayed (it won't render download button). Test with other combinations from Application Types and Application Address as it's all connected.

Checklist:

Reviewer Notes:

Steps to review a PR:

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

netlify[bot] commented 1 year ago

Deploy Preview for detroit-partners-dev ready!

Name Link
Latest commit a0674e93c0323e3d44f4938f9d1029b13dc3028a
Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/6450d33d95824d0008d8ba6a
Deploy Preview https://deploy-preview-1621--detroit-partners-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for detroit-public-dev ready!

Name Link
Latest commit a0674e93c0323e3d44f4938f9d1029b13dc3028a
Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/6450d33df4008c0008d5cd24
Deploy Preview https://deploy-preview-1621--detroit-public-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.