There is no issue associated here. Without internet on a plane / access to current tickets, I just got bored & made some Arabic layout fixes. You can see screenshots of each of them here.
UIC doesn't support RTL yet so these are overrides.
How Can This Be Tested/Reviewed?
You can check out the doc to see what changed.
Checklist:
[x] My code follows the style guidelines of this project
[ ] I have added QA notes to the issue with applicable URLs
[x] I have performed a self-review of my own code
[x] I have reviewed the changes in a desktop view
[x] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have run yarn generate:client and/or created a migration if I made backend changes that require them
[ ] I have exported any new pieces added to ui-components
[x] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
[ ] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits
Reviewer Notes:
Steps to review a PR:
Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.
Pull Request Template
Description
There is no issue associated here. Without internet on a plane / access to current tickets, I just got bored & made some Arabic layout fixes. You can see screenshots of each of them here.
UIC doesn't support RTL yet so these are overrides.
How Can This Be Tested/Reviewed?
You can check out the doc to see what changed.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.