search

CityOfLosAngeles / aqueduct

A shared pipeline for building ETLs and batch jobs that we run at the City of LA for Data Science Projects. Built on Apache Airflow & Civis Platform
Apache License 2.0
21 stars 6 forks source link

Upstream Bolt Auth #93

Closed ian-r-rose closed 4 years ago

ian-r-rose commented 4 years ago

In #92 we created a custom Bolt authenticator. We should extract that and make a PR against mds-provider with that authenticator. cc @RMK0110 .

ian-r-rose commented 4 years ago

Work-in progress in https://github.com/CityofSantaMonica/mds-provider/pull/85

ian-r-rose commented 4 years ago

Now that CityofSantaMonica/mds-provider#85 has been merged, we should remove the Bolt authenticator from this repository. cc @RMK0110

hunterowens commented 4 years ago

We'll have to untag / upgrade mds-provider in requirements.txt

On Thu, Dec 5, 2019 at 10:50 AM Ian Rose notifications@github.com wrote:

Now that CityofSantaMonica/mds-provider#85 https://github.com/CityofSantaMonica/mds-provider/pull/85 has been merged, we should remove the Bolt authenticator from this repository. cc @RMK0110 https://github.com/RMK0110

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CityOfLosAngeles/aqueduct/issues/93?email_source=notifications&email_token=AANHXYVZWL6ZW3JHTE5DBADQXFEQBA5CNFSM4JKLHW4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGBXKFI#issuecomment-562263317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANHXYVRKJ2AF7M3QE6TVPTQXFEQBANCNFSM4JKLHW4A .

RMK0110 commented 4 years ago

Now that CityofSantaMonica/mds-provider#85 has been merged, we should remove the Bolt authenticator from this repository. cc @RMK0110

bolt_auth was removed from their system.

ian-r-rose commented 4 years ago

No, it's still here: https://github.com/CityOfLosAngeles/aqueduct/blob/9cb1fc23330f9b5a2a580f87e2d58fe356c80fa4/dags/transportation/dockless/dockless_elt.py#L110-L144

RMK0110 commented 4 years ago

The bolt authenticator class was removed in a recent push.