CityOfLosAngeles / hcid-lookup-tool

A lookup tool for data from LAHD. Repository has been archived 2022-10-13.
Apache License 2.0
0 stars 3 forks source link

Address master creation #38

Closed rhouse00 closed 7 years ago

rhouse00 commented 7 years ago

address.js has multiple methods for finding or creating a new entry into the address master list. Issue below needs to be resolved, so we know which method to use.

_addressmaster.js model corrected to allow null values and street number to an integer, to allow for indexing, to work with address.js

_bimscontroller.js checkAddress added a return and runConstructors functions added in console.log to work with address.js

Note: currently using createAddress6 from address.js

Issues:

  1. runConstructors is running if(rawBatch.length... multiple times, used console.log - inside if statement to confirm this.
  2. batch system is currently not working properly. SQL queries are being skipped over

Image for issue 2 - there should be approximately 100 sql queries (current batch size is 100) for each batch...

screen shot 2017-03-28 at 9 27 54 am

rhouse00 commented 7 years ago

Update: Eliminated duplication error occurring during Address Master creation.

Notes:

Still Need: Add foreign key to bims object sent to create function