CityOfLosAngeles / open-sdg-data-starter

A starting point for the data repository of an Open SDG platform implementation. Dev URL: https://sdg-data-starter-dev.itacloudops.org/
MIT License
1 stars 7 forks source link

SDG: Create indicator_1-1-1.csv #50

Closed kerrylacity closed 1 month ago

kerrylacity commented 6 months ago

Hi Jaylen,

This is a new, updated .csv file, and I want it to replace the original Indicator_1-1-1.csv which is now out of date.

Would it best to delete the other Indicator so the SDG website does not show conflicting data sets?

Thank you.

What does this PR do?

Background info

How can this be tested (manually and/or automated test)?

Provide manual tests steps if applicable

Provide steps for running automated tests if applicable

Which issue(s) is/are related to this PR?

This PR is/are related to issue(s)

close

jaylenw commented 6 months ago

Hello @kerrylacity , If I understood your question correctly, you will want to replace the file https://github.com/CityOfLosAngeles/open-sdg-data-starter/blob/ac7f704e6511785db9bf85fc347a4434ccc550c5/data/indicator_1-1-1.csv#L4 with the file you are proposing in this PR. When you do so and make a commit, you should see a diff on this page showing what has been added, modified, and/or deleted. Once merged, the data dev site will have the updated changes. Please note the pipeline is still broken so sdgdata.lamayor.org won't reflect the update yet until it is fixed but you will see it if you start the site on your local environment.

kerrylacity commented 6 months ago

I see.

So instead of introducing a new .csv, I can go to the existing .csv and drop the new information? And commit that branch?

Thank you.

Kerry Sempelsz Olympic & Paralympic Development Intern Office of Mayor Karen Bass City of Los Angeles

On Thu, May 2, 2024, 5:42 PM Jaylen Wimbish @.***> wrote:

Hello @kerrylacity https://github.com/kerrylacity , If I understood your question correctly, you will want to replace the file https://github.com/CityOfLosAngeles/open-sdg-data-starter/blob/ac7f704e6511785db9bf85fc347a4434ccc550c5/data/indicator_1-1-1.csv#L4 with the file you are proposing in this PR. When you do so and make a commit, you should see a diff on this page https://github.com/CityOfLosAngeles/open-sdg-data-starter/pull/50/files showing what has been added, modified, and/or deleted. Once merged, the data dev site will have the updated changes. Please note the pipeline is still broken so sdgdata.lamayor.org won't reflect the update yet until it is fixed but you will see it if you start the site on your local environment.

— Reply to this email directly, view it on GitHub https://github.com/CityOfLosAngeles/open-sdg-data-starter/pull/50#issuecomment-2091961347, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFI7OQ24GATZ3GJBK6UGALLZALMP7AVCNFSM6AAAAABHETHAUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRHE3DCMZUG4 . You are receiving this because you were mentioned.Message ID: @.***>

jaylenw commented 6 months ago

I see. So instead of introducing a new .csv, I can go to the existing .csv and drop the new information? And commit that branch? Thank you. Kerry Sempelsz Olympic & Paralympic Development Intern Office of Mayor Karen Bass City of Los Angeles On Thu, May 2, 2024, 5:42 PM Jaylen Wimbish @.> wrote: Hello @kerrylacity https://github.com/kerrylacity , If I understood your question correctly, you will want to replace the file https://github.com/CityOfLosAngeles/open-sdg-data-starter/blob/ac7f704e6511785db9bf85fc347a4434ccc550c5/data/indicator_1-1-1.csv#L4 with the file you are proposing in this PR. When you do so and make a commit, you should see a diff on this page https://github.com/CityOfLosAngeles/open-sdg-data-starter/pull/50/files showing what has been added, modified, and/or deleted. Once merged, the data dev site will have the updated changes. Please note the pipeline is still broken so sdgdata.lamayor.org won't reflect the update yet until it is fixed but you will see it if you start the site on your local environment. — Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFI7OQ24GATZ3GJBK6UGALLZALMP7AVCNFSM6AAAAABHETHAUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRHE3DCMZUG4 . You are receiving this because you were mentioned.Message ID: @.>

@kerrylacity , yes correct, in your existing branch now, kerrylacity-patch-6, find and replace the file, or copy the contents you want and place it in the file, then commit to kerrylacity-patch-6.

kerrylacity commented 6 months ago

Thank you for your reply.

Your understanding is correct. Alright, when updating the .csv's, I will commit the change. I believe either Naomi or Jaylen have reviewer authority and can push this change to the starter branch.

Kerry Sempelsz

Olympic & Paralympic Development Intern

Phone: (818) 606-6521

Office of Mayor Karen Bass

Sign up for updates from the Mayor here https://mayor.lacity.gov/sign

On Thu, May 2, 2024 at 6:02 PM Jaylen Wimbish @.***> wrote:

I see. So instead of introducing a new .csv, I can go to the existing .csv and drop the new information? And commit that branch? Thank you. Kerry Sempelsz Olympic & Paralympic Development Intern Office of Mayor Karen Bass City of Los Angeles … <#m5697620462235041535> On Thu, May 2, 2024, 5:42 PM Jaylen Wimbish @.> wrote: Hello @kerrylacity https://github.com/kerrylacity https://github.com/kerrylacity https://github.com/kerrylacity , If I understood your question correctly, you will want to replace the file https://github.com/CityOfLosAngeles/open-sdg-data-starter/blob/ac7f704e6511785db9bf85fc347a4434ccc550c5/data/indicator_1-1-1.csv#L4 https://github.com/CityOfLosAngeles/open-sdg-data-starter/blob/ac7f704e6511785db9bf85fc347a4434ccc550c5/data/indicator_1-1-1.csv#L4 with the file you are proposing in this PR. When you do so and make a commit, you should see a diff on this page https://github.com/CityOfLosAngeles/open-sdg-data-starter/pull/50/files https://github.com/CityOfLosAngeles/open-sdg-data-starter/pull/50/files showing what has been added, modified, and/or deleted. Once merged, the data dev site will have the updated changes. Please note the pipeline is still broken so sdgdata.lamayor.org http://sdgdata.lamayor.org won't reflect the update yet until it is fixed but you will see it if you start the site on your local environment. — Reply to this email directly, view it on GitHub <#50 (comment) https://github.com/CityOfLosAngeles/open-sdg-data-starter/pull/50#issuecomment-2091961347>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFI7OQ24GATZ3GJBK6UGALLZALMP7AVCNFSM6AAAAABHETHAUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRHE3DCMZUG4 https://github.com/notifications/unsubscribe-auth/BFI7OQ24GATZ3GJBK6UGALLZALMP7AVCNFSM6AAAAABHETHAUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRHE3DCMZUG4 . You are receiving this because you were mentioned.Message ID: @.>

@kerrylacity https://github.com/kerrylacity , yes correct, in your existing branch now, kerrylacity-patch-6, find and replace the file, or copy the contents you want and place it in the file, then commit to kerrylacity-patch-6.

— Reply to this email directly, view it on GitHub https://github.com/CityOfLosAngeles/open-sdg-data-starter/pull/50#issuecomment-2091974003, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFI7OQ4CEE3BU4DPTIX5MPDZALO4DAVCNFSM6AAAAABHETHAUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJRHE3TIMBQGM . You are receiving this because you were mentioned.Message ID: @.***>