Use PDF.js instead of embed

CityOfNewYork / DORIS-Publications-Portal

DORIS Publications Portal

3 stars 6 forks source link

Use PDF.js instead of embed #18

Closed jqnatividad closed 9 years ago

jqnatividad commented 9 years ago

As per #12. Tried deploying DORIS on my Ubuntu box, but it got too hairy and have a lot of site-specific dependencies so didn't really get a chance to test.

Reasonably confident it should work having just enabled PDF.js on CKAN

estevez90 commented 9 years ago

Hi @jqnatividad

I tried it on my machine and it looks like viewer.html references a missing js file: https://github.com/jqnatividad/DORIS-Publications-Portal/blob/master/application/doris_gpp-2.0.0/static/js/pdfjs-1.1.1-dist/web/viewer.html#L37

jqnatividad commented 9 years ago

Hi @estevez90, Mea culpa. The js files were not there coz build dir was in .gitignore: https://github.com/CityOfNewYork/DORIS-Publications-Portal/blob/master/.gitignore#L13.

I've since added the js files.