Text populated based on low sample-size indicators

CityOfPhiladelphia / community-health-explorer

Host, edit and visualize CSV-based data using Jekyll, Leaflet & Chartist

http://healthexplorer.phila.gov

23 stars 8 forks source link

Text populated based on low sample-size indicators #43

Closed MeaganLP closed 8 years ago

MeaganLP commented 8 years ago

Sample size 1, 2, and 3 codes:

When 3: where sample size is low, so information is not displayed:
[ ] Please show this text: "Data missing for some race/ethnic subgroups due to small sample size." instead of the current, "Sample size inadequate: Asian";;;;;;;;
[ ] For Planning districts please show: "Data missing for some planning districts due to small sample size."

*unless we do something different to solve this? Launch

MeaganLP commented 8 years ago

Can you tell me what self-serve means? Usually I would consider text changes something we should do in prose, but these particular texts were populated into the notes field through code, I thought.

laurenancona commented 8 years ago

@MeaganLP apologies, I meant to Slack you about that! That was a lo-fi, manual solution because there weren't that many of them. That text is just in the chartComments field, so for anything like those, it would be awesome if you could take a shot at updating. Let me know if that's not what you're referring to, or I'm otherwise misunderstanding.

laurenancona commented 8 years ago

@MeaganLP @Kistine @AmoryH To be clear: you'd like these more generalized statements to replace the current versions that names the specific missing data?

MeaganLP commented 8 years ago

Depending on which situation you're talking about (between the 2 and 3 designation). Perhaps we should chat by phone @laurenancona quickly so that no unnecessary work gets done? I'm free after 4 today or in the morning.

laurenancona commented 8 years ago

@MeaganLP I'm in DC at a mapping event until EOD today, but can do a call tmrw?

So what I'm reading is for these changes are only for designation 3?

MeaganLP commented 8 years ago

We had a correction for designation 3 that needs to change before launch and a small adjustment for designation 2 that can be considered an enhancement.

Let's check in briefly tomorrow. Let me know what time works best for you - I'm free all day, but would prefer a call after 10:30 if that wouldn't cause a hold up.

MeaganLP commented 8 years ago

@laurenancona

laurenancona commented 8 years ago

I'm going to take a pass at this right now, with the provision that it's easily rolled back if not what you mean, @MeaganLP.