search

CityOfPhiladelphia / community-health-explorer

Host, edit and visualize CSV-based data using Jekyll, Leaflet & Chartist
http://healthexplorer.phila.gov
23 stars 8 forks source link

Text Size #45

Closed AmoryH closed 8 years ago

AmoryH commented 8 years ago

The description text is much larger than the note and source text for Planning District, Citywide Over Time, and Top 10. All text should be the same size. Maybe make all text the larger size so it's easier to read.

laurenancona commented 8 years ago

This is an intentional design decision; the two fields note and source are intended to be clarifying/annotation-style content, whereas description is body content.

MeaganLP commented 8 years ago

I agree with Lauren about leaving the Description text larger than the rest.

Kistine commented 8 years ago

I'm a fan too of the styling - makes it easier to quickly understand that they're notations - otherwise, I think thinks like '5 year estimate' might feel unfinished and out of place.

MeaganLP commented 8 years ago

However, if we could make the racial disparity tab match the others that would be good. Right now Description is not larger on that page.

AmoryH commented 8 years ago

Okay, I can get on board with that.

laurenancona commented 8 years ago

@MeaganLP That's a bug; will fix.

laurenancona commented 8 years ago

Description is correctly displaying larger for me, closing for now.

AmoryH commented 8 years ago

Still not displaying larger on our end for racial disparity.

laurenancona commented 8 years ago
laurenancona commented 8 years ago

Fixed in https://github.com/CityOfPhiladelphia/community-health-explorer/commit/1bd068ba55d47e889c067e456db79602b37a46ac