CityOfPhiladelphia / community-health-explorer

Host, edit and visualize CSV-based data using Jekyll, Leaflet & Chartist
http://healthexplorer.phila.gov
23 stars 8 forks source link

Planning districts - SHS exposure not showing up #49

Closed MeaganLP closed 8 years ago

MeaganLP commented 8 years ago

@laurenancona SHS exposure is not showing up for any planning district; Maybe this is an easy bug to fix?

Kistine commented 8 years ago

@MeaganLP - not sure if you saw my slack but I just double-checked the data and the regions for which the second-hand smoke or excessive drinking cards don't appear is because the data field is empty. are you not seeing SHS AT ALL for ANY district?

laurenancona commented 8 years ago

screen shot 2016-07-08 at 11 00 20 am

Note: #50 is a duplicate of this issue

laurenancona commented 8 years ago

@MeaganLP @AmoryH Have tested this in Firefox 47 on Windows 7-10, Mac back to Yosemite. I'll work through the rest of the common OS browser combos, but please let me know if you encounter any other specific combos and I'll try to reproduce.

laurenancona commented 8 years ago

Testing

Machine Network OS Browser Version Notes
Ancona LTE OSX 10.10 Chrome current OK
Ancona LTE OSX 10.10 Safari current OK
Browserstack BS Win 7-10 Firefox 47.0.1 OK
Hannah Health LAN Win 7 Chrome current OK
laurenancona commented 8 years ago

@AmoryH @MeaganLP @Kistine @timwis Ok. We've isolated the issue to when you use the dropdown to change planning district - it does not add/remove the class to hide/show indicators with null, 0, or 0% values, whereas when you use the map to select, this works correctly.

To reproduce: after page loads, scroll or jump to Tobacco & Alcohol Category, try changing the planning district via the map, and then try same via the dropdown. E.g.: Central (loaded by default) has no data for Secondhand Smoke exposure, so there should be 3 indicators, and when you select Lower North (directly above Central) a 4th indicator (Secondhand Smoke) should appear.

Kistine commented 8 years ago

bizarro!

laurenancona commented 8 years ago

Waiting for results of exec review before making any more changes on this.

laurenancona commented 8 years ago

closed in fd16a59