search

CityOfPhiladelphia / interaction-testers

Provides a REST API to execute headless browser tests, which can then be used like uptime checks
3 stars 2 forks source link

convert test command to node script #7

Closed ajrothwell closed 6 years ago

ajrothwell commented 6 years ago

I was unable to run the test command on windows because it uses bash syntax. This pr converts that command to a node script that runs on all platforms.

timwis commented 6 years ago

Wow, cool! Code changes look good to me. If you can verify that this doesn't break existing functionality (it's currently running on a Linux box in aws) then I'd say you're good to merge!

On a separate note, Google chrome released a tool called puppeteer that is even easier to use than Casper. May be worth looking to that for the next version of this project, if there's still utility for it. And the graphcool team wrote a wrapper around it to run it as a lambda function, which is pretty cool (https://github.com/graphcool/chromeless)

ajrothwell commented 6 years ago

@timwis Sounds good. This is only changing the test command, and my guess is the Linux machine is using server, so we should be good.

This accidentally tried to deploy from the PR branch and failed -- we got an error that deploy.sh exited wth a status of 1. So the same thing will probably happen when we merge. Any ideas how Travis used to do that?

ajrothwell commented 6 years ago

Actually we figured it out -- we were looking at the wrong deploy.sh. Looks like it should work when we merge.

bertday commented 6 years ago

@timwis Puppeteer looks nice! I was actually meaning to ask if you'd consider a new branch of interaction-testers that swaps out Casper for one of the newer libraries. I've been looking into using Nightwatch for some of our other projects. Apparently there's a SaaS version in the works, which would be ideal, but still no word on it: https://nightcloud.io/