CityOfPhiladelphia / property2

Find information on real estate property in Philadelphia.
https://property.phila.gov
ISC License
6 stars 7 forks source link

Reflect user input in 400 errors #201

Closed bertday closed 7 years ago

bertday commented 7 years ago

Currently there's only error message displayed in Property: "Failed to retrieve results." This happens whether the issue is user-generated or coming from the backend.

This branch introduces a new message for user errors that reflects the search terms passed to AIS:

image

Looking over 404 errors in Sentry, it seems fairly common for users to search using the wrong type, for instance Block instead of Address. This should help mitigate some of the confusion with the dropdown until there's a longer-term UI replacement (e.g. tabs).

Closes #119

karissademi commented 7 years ago

Looks good to me!

bertday commented 7 years ago

Thanks for taking a look @karissademi @timwis !