search

CityOfPhiladelphia / property2

Find information on real estate property in Philadelphia.
https://property.phila.gov
ISC License
6 stars 7 forks source link

Add proposed tax estimate feature #220

Closed timwis closed 6 years ago

timwis commented 6 years ago

Pending OPA/Finance approval. Merge to deploy once approved. I'm out of the office on Friday 4/20.

/cc @rbrtmrtn @tswanson

bertday commented 6 years ago

This looks nice and is working well for me. My only suggestion would be to remove the "Estimate" button, since after you click it there's no way to get it to come back. Other than that, I think this is good to go, if we ultimately decide to put this into Property.

timwis commented 6 years ago

Thanks @rbrtmrtn the reason that was added was to decrease the likelihood someone might assume the number is their 2019 taxes -- it's just an estimate of the taxes based on the two rates being discussed, and doesn't account for certain tax assistance programs like OOPA (as far as I know). By making them click the "estimate" button, it (hopefully) increases the likelihood that they're aware it's an estimate. And it's a carry-over from the avi calculator.

bertday commented 6 years ago

Thanks @timwis, sounds good. We were seeing a few issues with how the homestead exemption was getting applied so I pushed a few changes. I don't think I can deploy to your Surge site, so I'll create another demo and send it out.

tswanson commented 6 years ago

Don't push any updates until we get signoff on the changes that have been document

bertday commented 6 years ago

@tswanson Sure thing, we'll pick up next week.