search

CityOfZion / neo-local

Personal blockchain for NEO dApp development!
MIT License
52 stars 26 forks source link

Update to neopython v0.8.3 #152

Closed nunojusto closed 5 years ago

nunojusto commented 5 years ago

Problem

solving #150 Update neo-python to v0.8.3

Solution

change configs and docker-compose

Checklist

nunojusto commented 5 years ago

When running make start I see the following output

[neo-local] Network running! tada [neo-local] Attaching terminal to neo-python client Open wallet (password: 'coz'): open wallet ./neo-privnet.wallet Test smart contract: build /smart-contracts/wake_up_neo.py test 07 05 True False main Privatenet useragent '/Neo:2.9.0/', nonce: 1355295840

The command for opening a wallet and deploying a contract have changed

open wallet ./neo-privnet.wallet

should become

wallet open neo-privnet.wallet

build /smart-contracts/wake_up_neo.py test 07 05 True False main

should become

sc build_run /smart-contracts/wake_up_neo.py True False False 07 05 main

Note how it includes a 3rd boolean (for the payable flag) and the order of flags vs input/return types has changed.

Other than that it appears to sync as expected, it uses the 0.8.3 code as expected and I can open the provided wallet. This tells me the rest should work fine as far as the cli. If there are no other areas that interact with neo-python then the above changes should be all.

Ho, yes, i forgot those changes. Ok , thanks

ixje commented 5 years ago

fyi; we've released 0.8.4 about 1.5 weeks ago. This was an urgent release to support attaching fees to all transactions and smart contract deployments to work with the new policy change on the network. Otherwise TX's bigger than 1024 bytes would all fail.

I think there's not much else to do for neo-local other than including the new version. There should be no breaking changes.

nunojusto commented 5 years ago

fyi; we've released 0.8.4 about 1.5 weeks ago. This was an urgent release to support attaching fees to all transactions and smart contract deployments to work with the new policy change on the network. Otherwise TX's bigger than 1024 bytes would all fail.

I think there's not much else to do for neo-local other than including the new version. There should be no breaking changes.

OK, i will upgrade today later. Thanks