Fix neo-scan and use latest version

[adrienmo]

Rather than building a neoscan image, the docker-compose can refer directly to a production ready container that supports custom variables to configure the host/nodes/notifications server. For this reason the neo-scan folder is now useless. One neo-python container in the docker network was added to act as the local notification server.

custom-config.json for the notification server was copied from the privnet example but the ip of nodes where changed (--privnet and --host options cannot be used together unfortunately).

[vncoelho]

Good moves, adrienmo.

You are good on it! :dagger:

[adrienmo]

The new version now run on : http://localhost:4000 it can be started with docker-compose up -d

or

NOTIFICATIONS_SERVER=172.20.0.4 SEED_SERVER=172.20.0.2 docker-compose up -d

[jeroenptrs]

You can now additionally configure the host name: HOST_NAME=neoscanlocal.com NOTIFICATIONS_SERVER=172.20.0.4 SEED_SERVER=172.20.0.2 docker-compose up -d

This way, if you're setting up a central private testnet for an event, you can add your IP (let's say 123.4.5.6 for example) and everyone can connect to neoscan, the nodes (via neoscan) and the notifications-db with: HOST_NAME=123.4.5.6 NOTIFICATIONS_SERVER=123.4.5.6 SEED_SERVER=123.4.5.6 docker-compose up -d

If you don't want to allow them access to the notifications server f.e., you can just leave out that part of the command

[jeroenptrs]

Just wanted to clarify that you can do this with make as well: HOST_NAME=123.4.5.6 NOTIFICATIONS_SERVER=123.4.5.6 SEED_SERVER=123.4.5.6 make start

[jeroenptrs]

@revett linted the json, no changes to any docker commands. This works out of the box with docker-compose and make 😆