Fix parsing spaces - Githubissues

jseagrave21 commented 5 years ago

What current issue(s) does this address, or what feature is it adding? Addresses https://github.com/CityOfZion/neo-python/issues/1009 (see test_attribute_spacing)

How did you solve this problem? The input parser now merges strings until the count of "[" matches "]" or there is an IndexError (e.g. parsing a bytearray).

NOTE:

results in an extra space when parsing nested lists (i.e. ] ]]), which is still processed correctly
results in one string for an unmatched bracket, which is still acceptable

(see tests for examples)

How did you make sure your solution works? unittest and manual testing in privatenet

Are there any special changes in the code that we should be aware of? No

Please check the following, if applicable:

[x] Did you add any tests?
[x] Did you run make lint?
[x] Did you run make test?
[x] Are you making a PR to a feature branch or development rather than master?
[x] Did you add an entry to CHANGELOG.rst? (if not, please do)

ixje commented 4 years ago

@hal0x2328 can you confirm this fixes your issue?

coveralls commented 4 years ago

Coverage increased (+0.008%) to 85.313% when pulling 52f6807fdd14c83d66f89cc960dd62f6a0206e6d on jseagrave21:fix-parsing-spaces into 1d81ce3fb25e4714cb54d01c7600c836eda68ff8 on CityOfZion:development.

ixje commented 4 years ago

was waiting for input from hal, he gave it on slack. Thanks for taking care of this 👍

CityOfZion / neo-python

Fix parsing spaces #1013