fix #1014 - Githubissues

CityOfZion / neo-python

Python Node and SDK for the NEO 2.x blockchain. For NEO 3.x go to our successor project neo-mamba

https://neo-python.readthedocs.io/en/latest/

MIT License

313 stars 189 forks source link

fix #1014 #1016

Closed ixje closed 4 years ago

ixje commented 4 years ago

What current issue(s) does this address, or what feature is it adding? fix #1014

How did you solve this problem? fix serialize() method of the GetBlocksPayload as indicated by @hal0x2328 's analysis.

How did you make sure your solution works? manually tested against 2.10.3 single node before and after fix.

Are there any special changes in the code that we should be aware of? no

Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[ ] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

coveralls commented 4 years ago

Coverage decreased (-0.003%) to 85.305% when pulling 30b98221b51981c54a09c4b8217ecb5036895509 on ixje:fix-1014 into e670bca642f4be209e65084b4b832fe22aa255fc on CityOfZion:development.