CityOfZion / neo-python

Python Node and SDK for the NEO 2.x blockchain. For NEO 3.x go to our successor project neo-mamba
https://neo-python.readthedocs.io/en/latest/
MIT License
313 stars 189 forks source link

Fix to the syntax warnings caused by comparing literals #1037

Closed ilkericyuz closed 4 years ago

ilkericyuz commented 4 years ago

What current issue(s) does this address, or what feature is it adding? There are 5 syntax warnings in 2 files in the current code. Warnings appear when neo-python is installed as a library in a separate project.

SyntaxWarning: "is not" with a literal. Did you mean "!="?

How did you solve this problem? Replaced them with != which is the proper way to compare literals.

How did you make sure your solution works? It doesn't raise syntax warning anymore.

Are there any special changes in the code that we should be aware of? no

Please check the following, if applicable:

ixje commented 4 years ago

Thanks!

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 85.312% when pulling 074b31d067267ec860bee267e33a25b8813570d7 on bitpanda-labs:syntax-warnings-fix into a7f8392c01104d43008edbc669374c9f1bbdcf0d on CityOfZion:development.