Speedup np-import when appending blocks - Githubissues

CityOfZion / neo-python

Python Node and SDK for the NEO 2.x blockchain. For NEO 3.x go to our successor project neo-mamba

https://neo-python.readthedocs.io/en/latest/

MIT License

313 stars 189 forks source link

Speedup np-import when appending blocks #962

Closed ixje closed 5 years ago

ixje commented 5 years ago

What current issue(s) does this address, or what feature is it adding? when we supplied the -a flag for appending blocks, the code would still deserialise all data

How did you solve this problem? skip block deserialization and move the file pointer directly to the next block until we've reached the current height

How did you make sure your solution works? manual testing

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[ ] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

coveralls commented 5 years ago

Coverage remained the same at 85.113% when pulling ab72804d877bb86f581c148c52456eecf525c0d4 on ixje:speedup-import into 82594df6f3326003762ed99146e6236b984a316e on CityOfZion:development.