Fix boolean StackItem return type for `GetBigInteger()` - Githubissues

CityOfZion / neo-python

Python Node and SDK for the NEO 2.x blockchain. For NEO 3.x go to our successor project neo-mamba

https://neo-python.readthedocs.io/en/latest/

MIT License

313 stars 189 forks source link

Fix boolean StackItem return type for `GetBigInteger()` #966

Closed ixje closed 5 years ago

ixje commented 5 years ago

What current issue(s) does this address, or what feature is it adding? audit of testnet block 735309 showed a deviating in VMState due to a wrong type returned by StackItem.Boolean.GetBigInteger() causing an exception.

How did you solve this problem? fix to actually return a BigInteger instead of an int.

How did you make sure your solution works? audit passes for the block

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

coveralls commented 5 years ago

Coverage increased (+0.002%) to 85.154% when pulling 56d2933956498798e44eb1f5e461cec77f4b1dbe on ixje:fix-boolean-stackitem into 7e292275298794d6286b755f32297132528af107 on CityOfZion:development.