CityOfZion / neo-python

Python Node and SDK for the NEO 2.x blockchain. For NEO 3.x go to our successor project neo-mamba
https://neo-python.readthedocs.io/en/latest/
MIT License
313 stars 189 forks source link

Workaround neo-cli accepting invalid contract parameter types #968

Closed ixje closed 5 years ago

ixje commented 5 years ago

What current issue(s) does this address, or what feature is it adding? audit of testnet block 846536 showed a deviating in VMstate due to the syscall Neo.Contract.Create accepting invalid ContractParameterType's whereas neo-python throwed exceptions. The issue is reported there: https://github.com/neo-project/neo/issues/827

How did you solve this problem? added a workaround to be inline with neo-cli, but should be fixed in neo-cli

How did you make sure your solution works? audit passes, make test

Are there any special changes in the code that we should be aware of? na/

Please check the following, if applicable:

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.009%) to 85.904% when pulling c416897caeecaef1ab5375fef9a9c6344ec8c6c6 on ixje:tmp-fix-invalid-contract-param into 366cb0c71db7c74f4c7570bbd18100f3890f34ba on CityOfZion:development.