What current issue(s) does this address, or what feature is it adding?
audit of testnet block 846536 showed a deviating in VMstate due to the syscall Neo.Contract.Create accepting invalid ContractParameterType's whereas neo-python throwed exceptions. The issue is reported there: https://github.com/neo-project/neo/issues/827
How did you solve this problem?
added a workaround to be inline with neo-cli, but should be fixed in neo-cli
How did you make sure your solution works?
audit passes, make test
Are there any special changes in the code that we should be aware of?
na/
Please check the following, if applicable:
[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)
Coverage decreased (-0.009%) to 85.904% when pulling c416897caeecaef1ab5375fef9a9c6344ec8c6c6 on ixje:tmp-fix-invalid-contract-param into 366cb0c71db7c74f4c7570bbd18100f3890f34ba on CityOfZion:development.
What current issue(s) does this address, or what feature is it adding? audit of testnet block
846536
showed a deviating in VMstate due to the syscallNeo.Contract.Create
accepting invalidContractParameterType
's whereasneo-python
throwed exceptions. The issue is reported there: https://github.com/neo-project/neo/issues/827How did you solve this problem? added a workaround to be inline with
neo-cli
, but should be fixed inneo-cli
How did you make sure your solution works? audit passes, make test
Are there any special changes in the code that we should be aware of? na/
Please check the following, if applicable:
make lint
?make test
?CHANGELOG.rst
? (if not, please do)