Add raw tx functionality - Githubissues

CityOfZion / neo-python

Python Node and SDK for the NEO 2.x blockchain. For NEO 3.x go to our successor project neo-mamba

https://neo-python.readthedocs.io/en/latest/

MIT License

313 stars 189 forks source link

Add raw tx functionality #981

Closed jseagrave21 closed 5 years ago

jseagrave21 commented 5 years ago

What current issue(s) does this address, or what feature is it adding? Currently, the RawTransaction class which is in development to address issue https://github.com/CityOfZion/neo-python/issues/886 cannot function after introduction of a mandatory snapshot variable. Please refer to this review/discussion: https://github.com/CityOfZion/neo-python/pull/974#pullrequestreview-258577445

How did you solve this problem?

makes snapshot optional for Transaction.GetScriptHashesForVerifying
adds necessary logic to ContractParametersContext

How did you make sure your solution works? manual testing

Are there any special changes in the code that we should be aware of? See above

Please check the following, if applicable:

[ ] Did you add any tests?
[x] Did you run make lint?
[ ] Did you run make test?
[x] Are you making a PR to a feature branch or development rather than master?
[x] Did you add an entry to CHANGELOG.rst? (if not, please do)

coveralls commented 5 years ago

Coverage decreased (-0.005%) to 85.288% when pulling 915f8412434611bcb9e4b0fcfced72070069a055 on jseagrave21:raw_tx-functionality into 467c3ea95801927084949c3484eb68892c2a8023 on CityOfZion:development.