update dynamic invoke check to use snapshots - Githubissues

CityOfZion / neo-python

Python Node and SDK for the NEO 2.x blockchain. For NEO 3.x go to our successor project neo-mamba

https://neo-python.readthedocs.io/en/latest/

MIT License

313 stars 189 forks source link

update dynamic invoke check to use snapshots #995

Closed ixje closed 5 years ago

ixje commented 5 years ago

What current issue(s) does this address, or what feature is it adding? audit of testnet block 2606285 showed a deviation in VM state due to the CheckDynamicInvoke function not using snapshots and accessing the data caching layer.

How did you solve this problem? make it use snapshots

How did you make sure your solution works? audit of the block now passes

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

coveralls commented 5 years ago

Coverage increased (+0.004%) to 85.283% when pulling 9fa41db6394237432bad42977710535c4e13d97e on ixje:fix-checkdynamicinvoke into 588120582e66a4fef27cd452b0dcbf8e0a28c5dc on CityOfZion:development.