fix contract destroy storage deletion - Githubissues

CityOfZion / neo-python

Python Node and SDK for the NEO 2.x blockchain. For NEO 3.x go to our successor project neo-mamba

https://neo-python.readthedocs.io/en/latest/

MIT License

313 stars 189 forks source link

fix contract destroy storage deletion #996

Closed ixje closed 5 years ago

ixje commented 5 years ago

What current issue(s) does this address, or what feature is it adding? audit of testnet block 2644593 showed that the Contract.Destroy SYSCALL would under certain conditions not delete all contract storage.

How did you solve this problem? fix key data lookup input for internal storage call of the DataCache

How did you make sure your solution works? audit of the said block now passes

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

coveralls commented 5 years ago

Coverage decreased (-0.01%) to 85.273% when pulling 3d4b784d7d7816f94c4cad87f8223897e89b3780 on ixje:fix-contract-destroy into d49a1adad93187bb88b7ca72b27a003e936c0d3e on CityOfZion:development.