use snapshot for ED/EDT validation - Githubissues

CityOfZion / neo-python

Python Node and SDK for the NEO 2.x blockchain. For NEO 3.x go to our successor project neo-mamba

https://neo-python.readthedocs.io/en/latest/

MIT License

313 stars 189 forks source link

use snapshot for ED/EDT validation #998

Closed ixje closed 5 years ago

ixje commented 5 years ago

What current issue(s) does this address, or what feature is it adding? audit of testnet block 2842737 showed a deviation in VM state due to not using snapshots for CALL_ED/EDT dynamic invoke validation. This should have been part of #995

How did you solve this problem? use same logic as #995

How did you make sure your solution works? audit of block passes

Are there any special changes in the code that we should be aware of?

Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[ ] Did you add an entry to CHANGELOG.rst? (if not, please do)

coveralls commented 5 years ago

Coverage decreased (-0.004%) to 85.263% when pulling 73f73ab1fe6e689b4561d74cfda7b2a7433728aa on ixje:check-dynamic-2 into a7993c29631fa4b6d4e9b5544cbaab41f2e0921f on CityOfZion:development.