search

CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
34 stars 24 forks source link

Rolling log #508

Open aboimpinto opened 6 years ago

aboimpinto commented 6 years ago

Rolling log should be configured The neo-python project has a default of rolling log of 3 rotation of 50Mbytes. Neo-sharp should implement this model as default too and keep the communication line with neo-python in order to have the same configured logging scenarios.

We should should look for framework best practices for the rolling logs.

shargon commented 6 years ago

Also we should be able to disable this logs

osmirnov commented 6 years ago

I was forced to make it rolling while working on sync. Please start with the requirements for this feature and to tweak the configuration in nlog.config.

shargon commented 6 years ago

@osmirnov is possible to disable logs in this config?

osmirnov commented 6 years ago

This is an initial configuration. I think there are many ways to disable logging. For example: <logger name="*" minlevel="Trace" writeTo="targetGeneralOutput" enabled="false" /> If you want to do it on fly I believe you need to use NLog APi, to find a logger by name and to set that property.

shargon commented 6 years ago

@osmirnov You save my SSD :)