search

CityOfZion / neo-sharp

Neo-sharp is a new core and node implementation of NEO focused on modular design, best coding practices and testability.
MIT License
35 stars 24 forks source link

Refactor peer connection to fix the peer sync #511

Closed aboimpinto closed 6 years ago

aboimpinto commented 6 years ago

refactor of the peer connection and message handling in order to fix the peer sync.

the fowling workflow in implemented

Sync workflow

I could be able to sync 1.272.127 blocks from Mainnet and the sync start failing because some of the transaction are not able to be persisted. This point need further investigation.

510

codecov[bot] commented 6 years ago

Codecov Report

Merging #511 into sync-development will decrease coverage by 2.59%. The diff coverage is 9.82%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           sync-development     #511     +/-   ##
===================================================
- Coverage             52.85%   50.26%   -2.6%     
===================================================
  Files                   303      330     +27     
  Lines                 12764    13495    +731     
===================================================
+ Hits                   6747     6783     +36     
- Misses                 6017     6712    +695
Impacted Files Coverage Δ
...rc/NeoSharp.Core/Extensions/ByteArrayExtensions.cs 90% <0%> (-10%) :arrow_down:
...oSharp.Core/Exceptions/InvalidEndpointException.cs 0% <0%> (ø)
src/NeoSharp.Core/NewNetwork/Node.cs 0% <0%> (ø)
...harp.Core/Exceptions/InvalidBlockOrderException.cs 0% <0%> (ø)
...rc/NeoSharp.Core/Extensions/IPAddressExtensions.cs 0% <0%> (ø)
.../NewNetwork/Handlers/BlockHeadersMessageHandler.cs 0% <0%> (ø)
...Core/Exceptions/InvalidStateDescriptorException.cs 0% <0%> (ø)
...ore/NewNetwork/Handlers/InventoryMessageHandler.cs 0% <0%> (ø)
...c/NeoSharp.Core/NewNetwork/Protocols/ProtocolV2.cs 0% <0%> (ø)
....Core/NewNetwork/Handlers/GetAddrMessageHandler.cs 0% <0%> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f12956d...a1280a8. Read the comment docs.

gubanotorious commented 6 years ago

Pull request getting merged to continue progress towards a working node at the cost of less test coverage in the interim.